Add CRL checking for client certificate #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client provides a certificate, make sure it is actually valid AND not revoked.
|
Oh, for this to actually work, you'll need to patch public_key: |
| fetch(Rest); | ||
| fetch([{uniformResourceIdentifier, "http"++_=URL}|Rest]) -> | ||
| lager:debug("getting CRL from ~p~n", [URL]), | ||
| inets:start(), |
There was a problem hiding this comment.
Do we have to worry about an error being returned here because it's already been started?
|
I don't mean to be overly pedantic here, but adding some docstrings to the functions would go a long way to being able to revisit this code later and know why it does certain things. |
| %% XXX the 'Issuer' we get passed here is actually a lie, public key treats the Authority Key Identifier as the 'issuer' | ||
| %% Read the CA certs out of the file | ||
| %{ok, Bin} = file:read_file(CACerts), | ||
| %CACerts = load_certs("/home/andrew/lavabit"), |
There was a problem hiding this comment.
These commented lines probably shouldn't be here.
Add comments; verify clean Dialyzer, test against Riak Test, and document SSL functions.
|
👍 once #40 is merged. Should address most of my comments in this PR. |
Vagabond
added a commit
that referenced
this pull request
Oct 19, 2013
Add CRL checking for client certificate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client provides a certificate, make sure it is actually valid AND
not revoked.
See also basho/riak_test#416